Re: [Xen-devel] [PATCH v5 6/8] libxl: introduce libxl__alloc_vdev

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH v5 6/8] libxl: introduce libxl__alloc_vdev"):
> On Fri, 2012-05-04 at 12:13 +0100, Stefano Stabellini wrote:
> > Introduce libxl__alloc_vdev: find a spare virtual block device in the
> > domain passed as argument.
...
> > +    libxl__device_disk_dev_number(blkdev_start, &disk, &part);
> 
> If you specify the default blkdev_start in xl as d0 instead of xvda
> doesn't at least this bit magically become portable to BSD etc too?

This bit is portable already.  It's specified in terms of the guest
device name rather than the host device name.  This may be confusing
but it saves on having a converter for host device names to disk
numbers.

> Or couldn't it actually be an int and save you parsing at all?

In general it's surely more friendly to allow the user to specify this
with a name, like we do with vdevs elsewhere.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel