Re: [Xen-devel] [PATCH v4 4/8] libxl: introduce libxl__device_disk_add_t [and 1 more messages]

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Stefano Stabellini writes ("[PATCH v5 4/8] libxl: introduce 
libxl__device_disk_add"):
> Introduce libxl__device_disk_add that takes an additional
> xs_transaction_t paramter.
> Implement libxl_device_disk_add using libxl__device_disk_add.
> Move libxl__device_from_disk to libxl_internal.c.
> No functional change.

The last time you posted this I wrote:

Ian Jackson writes ("Re: [Xen-devel] [PATCH v4 4/8] libxl: introduce 
libxl__device_disk_add_t"):
> Apart from that it's rather hard to review because this patch seems to
> have an awful lot of code motion mixed up with other changes.

Can you split the code motion out into a separate patch, so that we
can see what has changed in the code that is being moved ?

Also I think "no functional change" is stretching it a bit unless what
you mean is "no callers of libxl__device_disk_add yet".

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel