[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] ns16550.c's poll_port variable

  • To: Jan Beulich <JBeulich@xxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxx>
  • Date: Fri, 04 May 2012 13:03:24 +0100
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxx>
  • Delivery-date: Fri, 04 May 2012 12:03:54 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>
  • Thread-index: Ac0p7egB5aWCdwmCcUyc7rTf6Ze7FQ==
  • Thread-topic: ns16550.c's poll_port variable

On 04/05/2012 12:05, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

>> I'm unclear on exactly what you want to optimise away? Certainly the 8 bytes
>> per CPU of the poll_port variable isn't worth much optimising effort.
> Certainly not (and as you say they are actually needed, even if
> only rarely). But the pointlessly running timer(s) might be, as might
> the buffer(s) set up via serial_async_transmit().

We could delay {init,setup}_postirq until a corresponding serial handle has
been created via serial_parse_handle()? The logic might be a bit ugly and
spread across both serial.c and ns16550.c but not actually particularly

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.