Re: [Xen-devel] [PATCH] fix build error with seabios

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-04-25 at 10:10 +0100, Christoph Egger wrote:
> On 04/25/12 10:52, Ian Campbell wrote:
> 
> > On Wed, 2012-04-25 at 09:43 +0100, Christoph Egger wrote:
> >> On 04/25/12 10:07, Ian Campbell wrote:
> >>
> >>> On Tue, 2012-04-24 at 18:18 +0100, Ian Jackson wrote:
> >>>> Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with 
> >>>> seabios"):
> >>>>>
> >>>>> Pass PYTHON down to seabios, so seabios will
> >>>>> use same python binary as whole xen tree does.
> >>>>> Fixes build error on NetBSD.
> >>>>
> >>>> Ian, does this look sensible to you ?
> >>>
> >>> It exports $(PYTHON) to all subdirs of tools/firmware, but I guess that
> >>> is OK, so we might as well take this now.
> >>
> >>
> >> Thanks.
> 
> >>
> 
> >>> Does
> >>> subdirs-seabios: PYTHON=$(PYTHON)
> >>> (or something similar) work? Might be a better option in the future
> >>
> >> No, this doesn't work.
> > 
> > What about
> > subdir-all-seabios: PYTHON=...
> > ?
> 
> 
> No, doesn't work. I also tried without success:
> 
> subdirs-all-seabios
> subdir-all-seabios-dir
> subdirs-all-seabios-dir
> seabios-dir

Strange. Oh well I guess the original patch does the job.

Ian.

> 
> Christoph
> 
> >>>>
> >>>>> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
> >>>
> >>> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >>>
> >>>>>
> >>>>> ----------------------------------------------------------------------
> >>>>> diff -r ab552da976a3 tools/firmware/Makefile
> >>>>> --- a/tools/firmware/Makefile   Wed Apr 11 18:28:33 2012 +0200
> >>>>> +++ b/tools/firmware/Makefile   Fri Apr 13 16:22:23 2012 +0200
> >>>>> @@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y)
> >>>>>         false ; \
> >>>>>         fi
> >>>>>  endif
> >>>>> -       $(MAKE) subdirs-$@
> >>>>> +       $(MAKE) PYTHON=$(PYTHON) subdirs-$@
> >>>>>  
> >>>>>  
> >>>>>  .PHONY: install
> >>>>>
> >>>>> ----------------------------------------------------------------------
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel