[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 2/5] libxl: add libxl__xs_path_cleanup



Ian Jackson escribió:
Roger Pau Monne writes ("[Xen-devel] [PATCH v3 2/5] libxl: add 
libxl__xs_path_cleanup"):
Add a function which behaves like "xenstore-rm -t", and which will be used to
clean xenstore after unplug since we will be no longer executing
xen-hotplug-cleanup script, that used to do that for us.

This is all rather odd.  I hadn't previously noticed the existence of
xenstore-rm -t.

With the C xenstored, the RM command will delete a whole directory
tree, regardless of its contents.  This is documented in
docs/misc/xenstore.txt.

This is a recursive delete, from top to bottom, let me put an example which will make this clear, since probably the title is wrong. Imagine you have the following xenstore entry:

/foo/bar/baz = 123

If you do a:

xenstore-rm /foo/bar/baz

the following will remain in xenstore:

/foo/bar

What this function does is clean empty folders that contained the deleted entry, so using this function on /foo/bar/baz would have cleaned the whole directory.

The comment in xs.c near xs_rm, which says that directories must be
empty, seems to be wrong.

What does oxenstored do ?  I'm tempted to say that it should follow
the C xenstored behaviour.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.