Re: [Xen-devel] [PATCH v3 4/7] xl/libxl: add a blkdev_start parameter

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 17 Apr 2012, Ian Jackson wrote:
> Stefano Stabellini writes ("[Xen-devel] [PATCH v3 4/7] xl/libxl: add a 
> blkdev_start parameter"):
> > Introduce a blkdev_start in xl.conf and pass it to
> > libxl_domain_create_* and all the way through libxl_run_bootloader and
> > libxl__device_disk_local_attach.
> 
> Surely this should be passed in the domain config structure rather
> than being an adhoc parameter.

I don't think so, see below.

> If the problem with that is that it really ought to be host-global and
> come from xl.conf, then perhaps we need another config struct.  But
> really I think that's overkill.  There is nothing wrong with taking
> parameters from xl.conf and putting them in the libxl domain config.
 
Another host-global config struct is definitely overkill, but we cannot
really pass this parameter in the libxl domain config, because this
option has nothing to do with the domain config.
It would be confusing and incorrect.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel