Re: [Xen-devel] [PATCH 10 of 18] tools/libvchan: fix build errors caused by -Werror in node-select.c

[Olaf Hering <olaf@xxxxxxxxx>]

On Mon, Apr 02, Ian Jackson wrote:

> Olaf Hering writes ("[Xen-devel] [PATCH 10 of 18] tools/libvchan: fix build 
> errors caused by -Werror in node-select.c"):
> > tools/libvchan: fix build errors caused by -Werror in node-select.c
> > 
> > -O2 -Wall -Werror triggers these warnings:
> > 
> > node-select.c:57:6: warning: function declaration isn't a prototype 
> > [-Wstrict-prototypes]
> 
> These changes are correct.
> 
> > node-select.c: In function 'vchan_wr':
> > node-select.c:60:2: warning: ISO C90 forbids mixed declarations and code 
> > [-Wdeclaration-after-statement]
> 
> This one is a question of coding style.  Apparently libvchan uses
> mixed statements/declarations, so this should be fixed by changing the
> warning flags.

The warning is odd anyway since -std=gnu99 is requested.
I will split the patch to address both warnings.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel