Re: [Xen-devel] [PATCH] vMSI: fix ia64 build for 21577:c41ab909f08e

["KUWAMURA Shin'ya" <kuwa@xxxxxxxxxxxxxx>]

Hi Jan,

>>>>> On Fri, 23 Mar 2012 08:53:31 +0000
>>>>> JBeulich@xxxxxxxx("Jan Beulich")  said:
> 
> >>> On 23.03.12 at 09:00, "KUWAMURA Shin'ya" <kuwa@xxxxxxxxxxxxxx> wrote:
> > On ia64, 21577:c41ab909f08e introduces the following error:
> >   /xen/include/xen/pci.h:52: warning: implicit declaration of function 
> > `PFN_UP'
> >   /xen/include/xen/pci.h:52: error: variable-size type declared outside of 
> > any function
> >   /xen/include/xen/pci.h:53: error: variable-size type declared outside of 
> > any function
> > 
> > Because the macro PFN_UP() is defined on x86 only.
> > Notice: This patch is mainly backported for 23074:c80e0fb4fe93.
> And again, if you backport something you ought to include the
> original S-o-b.

Excuse me, S-o-b lines is here:

Signed-off-by: Keir Fraser <keir@xxxxxxx>
Signed-off-by: KUWAMURA Shin'ya <kuwa@xxxxxxxxxxxxxx>

Best regards,
-- 
  KUWAMURA Shin'ya

# HG changeset patch
# User KUWAMURA Shin'ya <kuwa@xxxxxxxxxxxxxx>
# Date 1332495323 -32400
# Node ID bc2c1b2caffc8ffbad5fd4028dc9547523b03096
# Parent  e49c3dcfa28a8fd53bd0b963269ba48e89efbf06
vMSI: fix ia64 build for 21577:c41ab909f08e

On ia64, 21577:c41ab909f08e introduces the following error:
  /xen/include/xen/pci.h:52: warning: implicit declaration of function `PFN_UP'
  /xen/include/xen/pci.h:52: error: variable-size type declared outside of any 
function
  /xen/include/xen/pci.h:53: error: variable-size type declared outside of any 
function

Because the macro PFN_UP() is defined on x86 only.

Signed-off-by: Keir Fraser <keir@xxxxxxx>
Signed-off-by: KUWAMURA Shin'ya <kuwa@xxxxxxxxxxxxxx>
xen-unstable changeset:   23074:c80e0fb4fe93
xen-unstable date:        Wed Mar 23 13:34:55 2011 +0000

diff -r e49c3dcfa28a -r bc2c1b2caffc xen/arch/x86/domain_build.c
--- a/xen/arch/x86/domain_build.c       Fri Mar 23 18:33:25 2012 +0900
+++ b/xen/arch/x86/domain_build.c       Fri Mar 23 18:35:23 2012 +0900
@@ -20,6 +20,7 @@
 #include <xen/bitops.h>
 #include <xen/compat.h>
 #include <xen/libelf.h>
+#include <xen/pfn.h>
 #include <asm/regs.h>
 #include <asm/system.h>
 #include <asm/io.h>
diff -r e49c3dcfa28a -r bc2c1b2caffc xen/arch/x86/e820.c
--- a/xen/arch/x86/e820.c       Fri Mar 23 18:33:25 2012 +0900
+++ b/xen/arch/x86/e820.c       Fri Mar 23 18:35:23 2012 +0900
@@ -4,6 +4,7 @@
 #include <xen/mm.h>
 #include <xen/compat.h>
 #include <xen/dmi.h>
+#include <xen/pfn.h>
 #include <asm/e820.h>
 #include <asm/page.h>
 #include <asm/processor.h>
diff -r e49c3dcfa28a -r bc2c1b2caffc xen/arch/x86/mm.c
--- a/xen/arch/x86/mm.c Fri Mar 23 18:33:25 2012 +0900
+++ b/xen/arch/x86/mm.c Fri Mar 23 18:35:23 2012 +0900
@@ -99,6 +99,7 @@
 #include <xen/event.h>
 #include <xen/iocap.h>
 #include <xen/guest_access.h>
+#include <xen/pfn.h>
 #include <asm/paging.h>
 #include <asm/shadow.h>
 #include <asm/page.h>
diff -r e49c3dcfa28a -r bc2c1b2caffc xen/arch/x86/msi.c
--- a/xen/arch/x86/msi.c        Fri Mar 23 18:33:25 2012 +0900
+++ b/xen/arch/x86/msi.c        Fri Mar 23 18:35:23 2012 +0900
@@ -17,6 +17,7 @@
 #include <xen/pci.h>
 #include <xen/pci_regs.h>
 #include <xen/keyhandler.h>
+#include <xen/pfn.h>
 #include <asm/io.h>
 #include <asm/smp.h>
 #include <asm/desc.h>
diff -r e49c3dcfa28a -r bc2c1b2caffc xen/arch/x86/numa.c
--- a/xen/arch/x86/numa.c       Fri Mar 23 18:33:25 2012 +0900
+++ b/xen/arch/x86/numa.c       Fri Mar 23 18:35:23 2012 +0900
@@ -13,6 +13,7 @@
 #include <xen/keyhandler.h>
 #include <xen/time.h>
 #include <xen/smp.h>
+#include <xen/pfn.h>
 #include <asm/acpi.h>
 #include <xen/sched.h>
 
diff -r e49c3dcfa28a -r bc2c1b2caffc xen/arch/x86/setup.c
--- a/xen/arch/x86/setup.c      Fri Mar 23 18:33:25 2012 +0900
+++ b/xen/arch/x86/setup.c      Fri Mar 23 18:35:23 2012 +0900
@@ -20,6 +20,7 @@
 #include <xen/rcupdate.h>
 #include <xen/vga.h>
 #include <xen/dmi.h>
+#include <xen/pfn.h>
 #include <xen/nodemask.h>
 #include <public/version.h>
 #ifdef CONFIG_COMPAT
diff -r e49c3dcfa28a -r bc2c1b2caffc xen/arch/x86/srat.c
--- a/xen/arch/x86/srat.c       Fri Mar 23 18:33:25 2012 +0900
+++ b/xen/arch/x86/srat.c       Fri Mar 23 18:35:23 2012 +0900
@@ -17,6 +17,7 @@
 #include <xen/nodemask.h>
 #include <xen/acpi.h>
 #include <xen/numa.h>
+#include <xen/pfn.h>
 #include <asm/e820.h>
 #include <asm/page.h>
 
diff -r e49c3dcfa28a -r bc2c1b2caffc xen/arch/x86/tboot.c
--- a/xen/arch/x86/tboot.c      Fri Mar 23 18:33:25 2012 +0900
+++ b/xen/arch/x86/tboot.c      Fri Mar 23 18:35:23 2012 +0900
@@ -6,6 +6,7 @@
 #include <xen/domain_page.h>
 #include <xen/iommu.h>
 #include <xen/acpi.h>
+#include <xen/pfn.h>
 #include <asm/fixmap.h>
 #include <asm/page.h>
 #include <asm/processor.h>
diff -r e49c3dcfa28a -r bc2c1b2caffc xen/include/asm-x86/page.h
--- a/xen/include/asm-x86/page.h        Fri Mar 23 18:33:25 2012 +0900
+++ b/xen/include/asm-x86/page.h        Fri Mar 23 18:35:23 2012 +0900
@@ -385,9 +385,6 @@ static inline uint32_t cacheattr_to_pte_
 
 #endif /* !__ASSEMBLY__ */
 
-#define PFN_DOWN(x)   ((x) >> PAGE_SHIFT)
-#define PFN_UP(x)     (((x) + PAGE_SIZE-1) >> PAGE_SHIFT)
-
 #endif /* __X86_PAGE_H__ */
 
 /*
diff -r e49c3dcfa28a -r bc2c1b2caffc xen/include/xen/pci.h
--- a/xen/include/xen/pci.h     Fri Mar 23 18:33:25 2012 +0900
+++ b/xen/include/xen/pci.h     Fri Mar 23 18:35:23 2012 +0900
@@ -12,6 +12,7 @@
 #include <xen/list.h>
 #include <xen/spinlock.h>
 #include <xen/pci_regs.h>
+#include <xen/pfn.h>
 #include <asm/page.h>
 
 /*
diff -r e49c3dcfa28a -r bc2c1b2caffc xen/include/xen/pfn.h
--- /dev/null   Thu Jan 01 00:00:00 1970 +0000
+++ b/xen/include/xen/pfn.h     Fri Mar 23 18:35:23 2012 +0900
@@ -0,0 +1,9 @@
+#ifndef __XEN_PFN_H__
+#define __XEN_PFN_H__
+
+#include <asm/page.h>
+
+#define PFN_DOWN(x)   ((x) >> PAGE_SHIFT)
+#define PFN_UP(x)     (((x) + PAGE_SIZE-1) >> PAGE_SHIFT)
+
+#endif /* __XEN_PFN_H__ */

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel