Re: [Xen-devel] [PATCH] [PATCH v3] Fetch the OVMF repository from specific git mirror and enable it

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-03-14 at 14:11 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [PATCH] [PATCH v3] Fetch the OVMF 
> repository from specific git mirror and enable it"):
> > tools: Add explicit clean rule for SeaBIOS
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Ta!

> This is unfortunately all rather fiddly.  Also even after this, "make
> clean" on a clean tree (without ./configure) fails:
> 
> /u/iwj/work/xen-unstable-tools.hg/tools/../tools/Rules.mk:7: 
> /u/iwj/work/xen-unstable-tools.hg/tools/../config/Tools.mk: No such file or 
> directory
> You have to run ./configure before building or installing the tools
> 
> I'm not sure if we care about that...

I noticed this too. I think there is unlikely to be much to cleanup if
configure hasn't been run? So I decided that it was sufficient that
        ./configure && make clean
works and that Tools.mk etc are only removed by distclean and not clean
(which I confirmed was the case).

I'm not sure what the alternatives would be, is there some mechanism by
which we could whitelist targets which do not require this include. Does
the contents of the subdirs recursed into for clean depend on the result
of running configure?

I'm happy to leave it as is. I suppose the "you have to run..." error
message could be made broader to cover all invocations of make which
recurse into tools.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel