Re: [Xen-devel] [PATCH v3 05/11] arm: shared_info page allocation and mapping

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-03-02 at 14:27 +0000, Stefano Stabellini wrote:
> @@ -118,7 +118,12 @@ static int create_p2m_entries(struct domain *d,
>          }
>          /* else: third already valid */
>  
> -        BUG_ON(third[third_table_offset(addr)].p2m.valid);
> +        if ( third[third_table_offset(addr)].p2m.valid )
> +        {
> +            /* p2m entry already present */
> +            free_domheap_page(
> +                    mfn_to_page(third[third_table_offset(addr)].p2m.base));
> +        }

If there was already an entry here don't we need to do something with
whatever it points to? Either free it or deref or something?

>  
>          /* Allocate a new RAM page and attach */
>          if (alloc) 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel