Re: [Xen-devel] [PATCH 2 of 2] PV-GRUB: add support for btrfs

[Teck Choon Giam <giamteckchoon@xxxxxxxxx>]

Hi Matt,

Sorry for a question about this patch.

I tried to apply this in my xen-4.1-testing changeset
23264:3f158dd40b31 tree but failed.  See comment below.  Thanks.

On Fri, Mar 9, 2012 at 11:03 AM, Matt Wilson <msw@xxxxxxxxxx> wrote:
> This patch adds btrfs support to the GRUB tree used to build PV-GRUB.
> The original patch is from Gentoo:
> https://bugs.gentoo.org/show_bug.cgi?id=283637
>
> Signed-off-by: Matt Wilson <msw@xxxxxxxxxx>
>

SNAP

> +diff -Nru grub-0.97-r9/stage2/builtins.c grub-0.97-r10/stage2/builtins.c
> +--- grub-0.97-r9/stage2/builtins.c     2009-12-10 23:41:37.000000000 +0100
> ++++ grub-0.97-r10/stage2/builtins.c    2009-12-10 23:41:15.000000000 +0100
> +@@ -2370,6 +2370,16 @@
> +         else
> + #endif /* GRUB_UTIL */
> +           {
> ++            /*
> +++            * FIXME: Ugly hack.
> +++            * Do not write to btrfs partition
> +++            * without a help of the file system!
> +++            */
> ++            if (!strcmp(fsys_table[fsys_type].name, "btrfs"))
> ++              {
> ++                errnum = ERR_BAD_ARGUMENT;
> ++                goto fail;
> ++              }
> +             if (! devwrite (*saved_sector - part_start, 1, stage2_buffer))

In stock grub-0.97 it is as below:

if (! devwrite (saved_sector - part_start, 1, stage2_buffer))

So my question is how you get it to apply in your tree without other
patch to change the above from saved_sector to *saved_sector?

I have tried to grep saved_sector string in xen tree which I believe
all other patches in grub.patches directory doesn't touch that line or
am I totally wrong about this?

Thanks.

Kindest regards,
Giam Teck Choon

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel