Re: [Xen-devel] [PATCH] xen: Add command line option to enable ASID support -- on by default

[Keir Fraser <keir.xen@xxxxxxxxx>]

On 07/03/2012 17:58, "George Dunlap" <george.dunlap@xxxxxxxxxxxxx> wrote:

> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

Why would you want to be able to disable the feature?

 -- Keir

> diff --git a/xen/arch/x86/hvm/svm/asid.c b/xen/arch/x86/hvm/svm/asid.c
> --- a/xen/arch/x86/hvm/svm/asid.c
> +++ b/xen/arch/x86/hvm/svm/asid.c
> @@ -24,12 +24,16 @@
>  #include <asm/amd.h>
>  #include <asm/hvm/nestedhvm.h>
>  
> +/* Xen command-line option to enable ASIDs */
> +static int opt_asid_enabled = 1;
> +boolean_param("asid", opt_asid_enabled);
> +
>  void svm_asid_init(struct cpuinfo_x86 *c)
>  {
>      int nasids = 0;
>  
>      /* Check for erratum #170, and leave ASIDs disabled if it's present. */
> -    if ( !cpu_has_amd_erratum(c, AMD_ERRATUM_170) )
> +    if ( opt_asid_enabled && !cpu_has_amd_erratum(c, AMD_ERRATUM_170) )
>          nasids = cpuid_ebx(0x8000000A);
>  
>      hvm_asid_init(nasids);
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel