Re: [Xen-devel] [PATCH] tools/qemu-xen: remove CFLAGS for qemu build

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Olaf Hering writes ("[Xen-devel] [PATCH] tools/qemu-xen: remove CFLAGS for qemu 
build"):
> tools/qemu-xen: remove CFLAGS for qemu build
> 
> Currently qemu-xen gets build with CFLAGS only if CFLAGS was already in
> the environment during make invocation. If CFLAGS is in environment then
> make will append all of the various flags specified in xen Makefiles,
> which is then passed to qemu configure. If CFLAGS is not set, then
> configure will use just "-O2 -g" because make does not export its own
> CFLAGS variable.
> 
> To make qemu-xen build consistent this change removes CFLAGS from the
> environment so that only the CFLAGS from qemu configure script will be
> used. This matches what is done in kvm.rpm and qemu.rpm where for
> example RPM_OPT_FLAGS is not passes as CFLAGS. Otherwise those packages
> would not build as well.

I think it is a bug to try to invoke the Xen build system with CFLAGS
set.  So I don't think it's a good idea to try to fix it up.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel