Re: [Xen-devel] [PATCH] configure: do not require Bison

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-02-29 at 14:51 +0000, Roger Pau Monnà wrote:
> 2012/2/29 Ian Campbell <ian.campbell@xxxxxxxxxx>:
> > I _think_ this isn't required because we also checkin the generated files. A
> > more complete fix might also allow the user to force regeneration but I 
> > didn't
> > both here.
> >
> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > ---
> >  tools/configure    |  559 
> > +++++++++++++++++++++++++---------------------------
> >  tools/configure.ac |    1 -
> 
> You forget to remove:
> 
> AC_ARG_VAR([BISON], [Path to Bison parser generator])
> from tools/configure.ac and also clean related variables from
> config/Tools.mk.in.
> 
Actually, thinking about this a bit more, I think we want to keep this
bit so that the bison binary is still configurable for those who are
changing those particular source files.

Hence I am just removing the AX_PATH_PROG_OR_FAIL relating to Bison and
Flex.

I have omitted the change to the generated file.

8<-------------------------------------------------------------

From 71dc4581d2226112f17308210f53a30189d4d562 Mon Sep 17 00:00:00 2001
From: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date: Wed, 29 Feb 2012 14:22:34 +0000
Subject: [PATCH] configure: do not require Bison or Flex

I _think_ this isn't required because we also checkin the generated files. A
more complete fix might also allow the user to force regeneration but I didn't
both here.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff --git a/tools/configure.ac b/tools/configure.ac
index 5b2815d..e6d8f4b 100644
--- a/tools/configure.ac
+++ b/tools/configure.ac
@@ -79,8 +79,6 @@ AC_PROG_MAKE_SET
 AC_PROG_INSTALL
 AX_PATH_PROG_OR_FAIL([PERL], [perl])
 AX_PATH_PROG_OR_FAIL([IP], [ip])
-AX_PATH_PROG_OR_FAIL([BISON], [bison])
-AX_PATH_PROG_OR_FAIL([FLEX], [flex])
 AS_IF([test "x$xapi" = "xy"], [
     AX_PATH_PROG_OR_FAIL([CURL], [curl-config])
     AX_PATH_PROG_OR_FAIL([XML], [xml2-config])
-- 
1.7.2.5




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel