Re: [Xen-devel] [PATCH v2 1/5] arm: shared_info page allocation and mapping

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

> > @@ -172,6 +177,14 @@ int map_mmio_regions(struct domain *d,
> >      return create_p2m_entries(d, 0, start_gaddr, end_gaddr, maddr);
> >  }
> >  
> > +int guest_physmap_add_page(struct domain *d, unsigned long gpfn,
> > +        unsigned long mfn)

Should these be either paddr_t or xen_pfn_t?

> > +{
> > +    return create_p2m_entries(d, 0, gpfn << PAGE_SHIFT,
> > +                              (gpfn + 1) << PAGE_SHIFT,
> > +                              mfn << PAGE_SHIFT);

As it stands you need to cast to paddr_t first so the shift won't
overflow.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel