Re: [Xen-devel] [PATCH 1/5] arm: shared_info page allocation and mapping

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Thu, 23 Feb 2012, Ian Campbell wrote:
> On Thu, 2012-02-23 at 17:13 +0000, Stefano Stabellini wrote:
> > Allocate the shared_info page at domain creation.
> > 
> > Implement arch_memory_op, only for XENMEM_add_to_physmap with space ==
> > XENMAPSPACE_shared_info, so that the guest can map the shared_info page.
> > 
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > ---
> >  xen/arch/arm/domain.c     |    8 ++++
> >  xen/arch/arm/mm.c         |   98 
> > +++++++++++++++++++++++++++++++++++++++++++--
> >  xen/arch/arm/p2m.c        |   15 ++++++-
> >  xen/include/asm-arm/mm.h  |    4 ++
> >  xen/include/asm-arm/p2m.h |    2 +
> >  5 files changed, 122 insertions(+), 5 deletions(-)
> > 
> > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> > index 0b55934..1e5cca5 100644
> > --- a/xen/arch/arm/domain.c
> > +++ b/xen/arch/arm/domain.c
> > @@ -235,6 +235,14 @@ int arch_domain_create(struct domain *d, unsigned int 
> > domcr_flags)
> >      if ( (rc = p2m_init(d)) != 0 )
> >          goto fail;
> >  
> > +    rc = -ENOMEM;
> > +   if ( (d->shared_info = alloc_xenheap_pages(0, MEMF_bits(32))) == NULL )
> > +           goto fail;
> > +
> > +   clear_page(d->shared_info);
> > +   share_xen_page_with_guest(
> > +                   virt_to_page(d->shared_info), d, XENSHARE_writable);
> 
> You seem to have some hard tabs here.

I realize that there are some tab problems in this series, I'll send it
out again.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel