Re: [Xen-devel] [xen-devel] [PATCH] libxl: fix compile error of libvirt

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-02-22 at 11:52 +0000, Ian Jackson wrote:
> Bamvor Jian Zhang writes ("Re: [Xen-devel] [xen-devel] [PATCH] libxl: fix 
> compile error of libvirt"):
> > Ian Jackson wrote: 
> > > Users of libxl should not be using libxc directly and therefore should 
> > > not be including xenctrl.h. 
> ...
> > but after your commit "23174:751c6dcec0d4"(remove xenctrl.h from libxl.h), 
> > the aplication(like libvirt) compile fail. How do i deal with it? 
> > it seems that add __XEN_TOOLS_ to libvirt code is not good. 
> 
> Can you tell us the error message you get ?  I think the problem is
> probably that libvirt is trying to use libxc directly.

Is the problem here libxc or the Xen public headers?

I thought we'd decided the latter was OK in users of libxl. e.g. xl has
to use the SHUTDOWN_{poweroff,reboot,suspend} constants from
xen/include/public/sched.h (and indeed libxl.h includes this header).

libxl.h also includes Xen's sysctl.h -- seems to be for
XEN_SYSCTL_PHYSCAP_*. Really this case would be better exposing as a
series of bools which are initialised from the hypercall provided flags
mask by libxl (like we do for the various dominfo flags)

Personally I'd be happy to have libxl always define its own constants
and remove this need for libxl users to use the Xen headers.

If we are going to do that it should go onto the 4.2 TODO list.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel