Re: [Xen-devel] [PATCH v5] build: add autoconf to replace custom checks in tools/check

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-02-21 at 10:17 +0000, Roger Pau Monné wrote:
> 2012/2/21 Ian Campbell <Ian.Campbell@xxxxxxxxxx>:
> > On Mon, 2012-02-20 at 22:18 +0000, Roger Pau Monne wrote:
> >>
> >> +# Autoscan stuff (except for yajl/yajl_version.h check)
> >
> > I don't understand this comment, the following AC_CHECK_HEADERS _does_
> > check for yajl_version.
> 
> Sorry, the comment is misleading, what I mean is that everything here
> is detected by autoscan, except for the yajl_version.h test that I've
> added myself. Should I change the comment?

I'd be tempted to just remove it. No one will update it when they add
another check not covered by autoscan.

> >
> >> +# Checks for header files.
> >> +AC_FUNC_ALLOCA
> >> +AC_CHECK_HEADERS([ \
> >> +                arpa/inet.h fcntl.h inttypes.h libintl.h limits.h 
> >> malloc.h \
> >> +                netdb.h netinet/in.h stddef.h stdint.h stdlib.h string.h \
> >> +                strings.h sys/file.h sys/ioctl.h sys/mount.h sys/param.h \
> >> +                sys/socket.h sys/statvfs.h sys/time.h syslog.h termios.h \
> >> +                unistd.h yajl/yajl_version.h \
> >> +                ])
> >



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xensource.com/xen-devel