[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3 of 7] Rework locking in the PoD layer


  • To: "George Dunlap" <George.Dunlap@xxxxxxxxxxxxx>
  • From: "Andres Lagar-Cavilla" <andres@xxxxxxxxxxxxxxxx>
  • Date: Thu, 9 Feb 2012 06:45:48 -0800
  • Cc: andres@xxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, tim@xxxxxxx, keir.xen@xxxxxxxxx, adin@xxxxxxxxxxxxxx
  • Delivery-date: Thu, 09 Feb 2012 14:46:08 +0000
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=lagarcavilla.org; h=message-id :in-reply-to:references:date:subject:from:to:cc:reply-to :mime-version:content-type:content-transfer-encoding; q=dns; s= lagarcavilla.org; b=JnjK/6O0+OkBVrCWk0Hnwc3rfuvvRVohZScEc1HAnMfP aCRNnk+9XUAuIAD5NCvY2aRWve7UqB/xObp/SXqEEFRLsoWBmcqhJG5wvnSX4I4W HXH06csxcfDKGQcH6StEpFRH+lDp16gYZJ5C8kDPNb/O/V3bys6ZmW9z+xUSKhM=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

> On Thu, Feb 9, 2012 at 5:45 AM, Andres Lagar-Cavilla
> <andres@xxxxxxxxxxxxxxxx> wrote:
>> @@ -114,15 +114,20 @@ p2m_pod_cache_add(struct p2m_domain *p2m
>>         unmap_domain_page(b);
>>     }
>>
>> +    /* First, take all pages off the domain list */
>>     lock_page_alloc(p2m);
>> -
>> -    /* First, take all pages off the domain list */
>>     for(i=0; i < 1 << order ; i++)
>>     {
>>         p = page + i;
>>         page_list_del(p, &d->page_list);
>>     }
>>
>> +    /* Ensure that the PoD cache has never been emptied.
>> +     * This may cause "zombie domains" since the page will never be
>> freed. */
>> +    BUG_ON( d->arch.relmem != RELMEM_not_started );
>> +
>> +    unlock_page_alloc(p2m);
>> +
>
> I thought we were going to get rid of this BUG_ON? :-)
>
> Other than that, assuming that you've tested it and it works:

Well, I've tested it for months. Does it work? Can that ever be fully
answered? ;)

>
> Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

Great, thanks George!

Tim, I can resend with BUG_ON eliminated and George's Acked-by. Or, wait
for more comments. Or, send a micro-patch later removing the BUG_ON.

Andres
>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.