Re: [Xen-devel] [PATCH 6 of 8] x86/mm: Properly account for paged out pages

[Olaf Hering <olaf@xxxxxxxxx>]

On Thu, Jan 26, Andres Lagar-Cavilla wrote:

> there is a put_page in case things go wrong, after the alloc_domheap_page
> call. So doing the decrement at alloc is a bit too soon.

Thats probably true.

But in the case of failure the guest will likely hang soon. Is the
copy_from_user() (and p2m_mem_paging_prep itself) restartable? If not,
the guest should probably be crashed.  The way xenpaging_populate_page()
is written right now, it will just exit, EFAULT isnt caught.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel