Re: [Xen-devel] [Qemu-devel] [PATCH 26/28] pci: convert to QEMU Object Model

[Anthony Liguori <anthony@xxxxxxxxxxxxx>]

On 01/25/2012 06:41 AM, Michael S. Tsirkin wrote:
> On Tue, Jan 24, 2012 at 01:33:18PM -0600, Anthony Liguori wrote:
> > diff --git a/hw/ac97.c b/hw/ac97.c
> > index 03be99b..33b85f5 100644
> > --- a/hw/ac97.c
> > +++ b/hw/ac97.c
> > @@ -1344,21 +1344,30 @@ int ac97_init (PCIBus *bus)
> >       return 0;
> >   }
> >
> > -static PCIDeviceInfo ac97_info = {
> > -    .qdev.name    = "AC97",
> > -    .qdev.desc    = "Intel 82801AA AC97 Audio",
> > -    .qdev.size    = sizeof (AC97LinkState),
> > -    .qdev.vmsd    =&vmstate_ac97,
> > -    .init         = ac97_initfn,
> > -    .exit         = ac97_exitfn,
> > -    .vendor_id    = PCI_VENDOR_ID_INTEL,
> > -    .device_id    = PCI_DEVICE_ID_INTEL_82801AA_5,
> > -    .revision     = 0x01,
> > -    .class_id     = PCI_CLASS_MULTIMEDIA_AUDIO,
> > -    .qdev.props   = (Property[]) {
> > -        DEFINE_PROP_UINT32("use_broken_id", AC97LinkState, use_broken_id, 0),
> > -        DEFINE_PROP_END_OF_LIST(),
> > -    }
> > +static Property ac97_properties[] = {
> > +    DEFINE_PROP_UINT32("use_broken_id", AC97LinkState, use_broken_id, 0),
> > +    DEFINE_PROP_END_OF_LIST(),
> > +};
> > +
> > +static void ac97_class_init(ObjectClass *klass, void *data)
> > +{
> > +    PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
> > +
> > +    k->init = ac97_initfn;
> > +    k->exit = ac97_exitfn;
> > +    k->vendor_id = PCI_VENDOR_ID_INTEL;
> > +    k->device_id = PCI_DEVICE_ID_INTEL_82801AA_5;
> > +    k->revision = 0x01;
> > +    k->class_id = PCI_CLASS_MULTIMEDIA_AUDIO;
> > +}
> > +
> > +static DeviceInfo ac97_info = {
> > +    .name = "AC97",
> > +    .desc = "Intel 82801AA AC97 Audio",
> > +    .size = sizeof (AC97LinkState),
> > +    .vmsd =&vmstate_ac97,
> > +    .props = ac97_properties,
> > +    .class_init = ac97_class_init,
> >   };
> >
> >   static void ac97_register (void)
> So I have a question on this: the whole reason
> we moved class, vendor id etc away from device init
> functions to a table was to make it possible
> to perform queries, like list all available sound device
> types, or sort devices based on type, based on these tables.
>
> Another purpose was to remove the manually written description/name,
> embedding pci id database in qemu instead, and performing
> lookups based on device/vendor id.
>
> We never got these patches but it sounds like a genuinely useful
> functionality.
>
> Is this no longer possible?
There is one class instance per type.  It's initialized lazily but the types are 
always known.  IOW, ac97_class_init() is called once on the global 
PCIDeviceClass object, most likely very early during init.
These class objects can be searched and interacted with independently of any 
existing object.  What you're after is:
static void show_pci_device(ObjectClass *klass, void *opaque)
{
    PCIDeviceClass *pc = PCI_DEVICE_CLASS(klass);

    printf("Device %s is %02x:%02x\n",
           object_class_get_name(klass), pc->vendor_id, pc->device_id);
}

{
    ...
    object_class_foreach(show_pci_device, TYPE_PCI_DEVICE, false, NULL);
}

Regards,

Anthony Liguori



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel