Re: [Xen-devel] [PATCH 3/3] xenoprof: Make the escape code consistent across 32 and 64-bit xen

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.01.12 at 18:40, George Dunlap <george.dunlap@xxxxxxxxxx> wrote:
> If I were writing this patch series from the beginning, I'd have one
> patch which "fixed" the various internal functions to use 64-bits for
> EIP, since even in 32-bit that value in the struct can be 64-bit.  That
> patch by itself could have a bug in it, and so as a reviewer /
> archaeologist, *I* would have preferred it did just that one thing, so I
> didn't have to figure out what each individual line was supposed to be
> doing.  Then the guest-visible functional change would have been its own
> patch.

This way round it would seem a reasonable split to me. Yet that
prerequisite patch wasn't sent as such, but instead as a follow up
one.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel