Re: [Xen-devel] [PATCH 09 of 12] Update memshr API and tools

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-01-16 at 02:56 +0000, Andres Lagar-Cavilla wrote:
> tools/blktap2/drivers/tapdisk-vbd.c |   6 +-
>  tools/blktap2/drivers/tapdisk.h     |   2 +-
>  tools/libxc/xc_memshr.c             |  63 
> ++++++++++++++++++++++++++++++++++--
>  tools/libxc/xenctrl.h               |  19 ++++++++++-
>  tools/memshr/bidir-daemon.c         |  34 ++++++++++++++-----
>  tools/memshr/bidir-hash.h           |  12 ++++--
>  tools/memshr/interface.c            |  30 ++++++++++-------
>  tools/memshr/memshr.h               |  11 +++++-
>  8 files changed, 139 insertions(+), 38 deletions(-)
> 
> 
> This patch is the folded version of API updates, along with the associated 
> tool
> changes to ensure that the build is always consistent.
> 
> API updates:
> - The source domain in the sharing calls is no longer assumed to be dom0.
> - Previously, the mem sharing code would return an opaque handle to index
>   shared pages (and nominees) in its global hash table.  By removing the hash
>   table, the handle becomes a version, to avoid sharing a stale version of a
>   page. Thus, libxc wrappers and tools need to be updated to recall the share
>   functions with the information needed to fetch the page (which they readily
>   have).
> 
> Tool updates:
> The only (in-tree, that we know of) consumer of the mem sharing API is the
> memshr tool. This is updated to use the new API.
> 
> Signed-off-by: Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>
> Signed-off-by: Adin Scannell <adin@xxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> at least as far  as the
libxc bits go. I don't know much about the memshr/blktap side of things
but the changes look sane to me.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel