Re: [Xen-devel] [PATCH 1 of 3] libxl: extend pCPUs specification for vcpu-pin.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Dario Faggioli writes ("Re: [Xen-devel] [PATCH 1 of 3] libxl: extend pCPUs 
specification for vcpu-pin."):
> Well, that's not properly me, is it that?
> 
> hg annotate tools/libxl/xl_cmdimpl.c
> ...
> 21247:     if (strcmp(cpu, "all")) { 
> 21247:         for (toka = strtok(cpu, ","), i = 0; toka; toka = strtok(NULL, 
> ","), ++i) {
> 21247:             cpuida = strtoul(toka, &endptr, 10);
> 21247:             if (toka == endptr) {
> ...

Oops, sorry for wrongly pointing the finger.

> Again, I know that's probably not an alibi, but that's not my code! :-P
> What I did is just move this from the body of vcpupin() to an helper
> function, and try to add as _less_ thing as I can to support a slightly
> improved syntax.

Right.

> That being said, if you think I should rewrite the parsing from scratch,
> I can think about it, just wanted to clarify my position. :-)

I really don't like the existing code here; feel free to do whatever
you think is best.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel