Re: [Xen-devel] [PATCH v4 10/25] arm: bit manipulation, copy and division libraries

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-01-09 at 17:59 +0000, stefano.stabellini@xxxxxxxxxxxxx
wrote:
> From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> 
> Bit manipulation, division and memcpy & friends implementations for the
> ARM architecture, shamelessly taken from Linux.

When I initially imported these I did so with the minimal changes
possible to integrate the in the Xen tree so as to aid future merges of
this code from Linux.

This meant there was quite a lot of ifdef'd code (in particular for
previous ARM architectures via __LINUX_ARM_ARCH__) but I think that is a
price worth paying to keep these files somewhat in sync. I used a pretty
ugly "#if 1 /* __LINUX_ARM_ARCH__ >= 5 */" construct to minimise changes
but perhaps it would be better to simply define __LINUX_ARM_ARCH__
appropriately within the lib subdirectory?

Ian.

> 
> 
> Changes in v2:
> 
> - implement __aeabi_uldivmod and __aeabi_ldivmod.
> 
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Signed-off-by: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
> ---
>  xen/arch/arm/lib/Makefile        |    5 +
>  xen/arch/arm/lib/assembler.h     |   49 ++++++
>  xen/arch/arm/lib/bitops.h        |   36 +++++
>  xen/arch/arm/lib/changebit.S     |   18 +++
>  xen/arch/arm/lib/clearbit.S      |   19 +++
>  xen/arch/arm/lib/copy_template.S |  266 +++++++++++++++++++++++++++++++++
>  xen/arch/arm/lib/div64.S         |  149 +++++++++++++++++++
>  xen/arch/arm/lib/findbit.S       |  115 +++++++++++++++
>  xen/arch/arm/lib/lib1funcs.S     |  302 
> ++++++++++++++++++++++++++++++++++++++
>  xen/arch/arm/lib/memcpy.S        |   64 ++++++++
>  xen/arch/arm/lib/memmove.S       |  200 +++++++++++++++++++++++++
>  xen/arch/arm/lib/memset.S        |  129 ++++++++++++++++
>  xen/arch/arm/lib/memzero.S       |  127 ++++++++++++++++
>  xen/arch/arm/lib/setbit.S        |   18 +++
>  xen/arch/arm/lib/testchangebit.S |   18 +++
>  xen/arch/arm/lib/testclearbit.S  |   18 +++
>  xen/arch/arm/lib/testsetbit.S    |   18 +++
>  17 files changed, 1551 insertions(+), 0 deletions(-)
>  create mode 100644 xen/arch/arm/lib/Makefile
>  create mode 100644 xen/arch/arm/lib/assembler.h
>  create mode 100644 xen/arch/arm/lib/bitops.h
>  create mode 100644 xen/arch/arm/lib/changebit.S
>  create mode 100644 xen/arch/arm/lib/clearbit.S
>  create mode 100644 xen/arch/arm/lib/copy_template.S
>  create mode 100644 xen/arch/arm/lib/div64.S
>  create mode 100644 xen/arch/arm/lib/findbit.S
>  create mode 100644 xen/arch/arm/lib/lib1funcs.S
>  create mode 100644 xen/arch/arm/lib/memcpy.S
>  create mode 100644 xen/arch/arm/lib/memmove.S
>  create mode 100644 xen/arch/arm/lib/memset.S
>  create mode 100644 xen/arch/arm/lib/memzero.S
>  create mode 100644 xen/arch/arm/lib/setbit.S
>  create mode 100644 xen/arch/arm/lib/testchangebit.S
>  create mode 100644 xen/arch/arm/lib/testclearbit.S
>  create mode 100644 xen/arch/arm/lib/testsetbit.S



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel