Re: [Xen-devel] [PATCH] xen-netback: make ops structs const

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-01-04 at 21:56 +0000, Stephen Hemminger wrote:
> All tables of function pointers should be const to make hacks
> more difficult. Compile tested only.

I also eyeballed for any writes to these structs and couldn't find one.

> Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> 
> ---
> Patch against net-next
> 
> --- a/drivers/net/xen-netback/interface.c     2011-12-07 10:54:19.232282492 
> -0800
> +++ b/drivers/net/xen-netback/interface.c     2012-01-04 13:16:04.414052721 
> -0800
> @@ -223,7 +223,7 @@ static void xenvif_get_strings(struct ne
>       }
>  }
>  
> -static struct ethtool_ops xenvif_ethtool_ops = {
> +static const struct ethtool_ops xenvif_ethtool_ops = {
>       .get_link       = ethtool_op_get_link,
>  
>       .get_sset_count = xenvif_get_sset_count,
> @@ -231,7 +231,7 @@ static struct ethtool_ops xenvif_ethtool
>       .get_strings = xenvif_get_strings,
>  };
>  
> -static struct net_device_ops xenvif_netdev_ops = {
> +static const struct net_device_ops xenvif_netdev_ops = {
>       .ndo_start_xmit = xenvif_start_xmit,
>       .ndo_get_stats  = xenvif_get_stats,
>       .ndo_open       = xenvif_open,



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel