Re: [Xen-devel] [PATCH] ipxe: update to upstream version

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.12.11 at 05:21, Roger Pau Monne <roger.pau@xxxxxxxxxxxxx> wrote:
> --- a/tools/firmware/etherboot/Makefile       Fri Dec 09 16:19:36 2011 +0000
> +++ b/tools/firmware/etherboot/Makefile       Tue Dec 20 05:20:02 2011 +0100
> @@ -10,9 +10,7 @@ else
>  IPXE_GIT_URL := git://git.ipxe.org/ipxe.git
>  endif
>  
> -IPXE_GIT_TAG := v1.0.0
> -
> -IPXE_TARBALL_URL := $(XEN_EXTFILES_URL)/ipxe-git-$(IPXE_GIT_TAG).tar.gz
> +IPXE_GIT_TREE := 540e5960dc6b49eacf367f7c319fd0546474b845

Is "TREE" really a meaningful name tag here? "COMMIT" would seem
more reasonable to me.

>  
>  D=ipxe
>  T=ipxe.tar.gz
> @@ -35,12 +33,10 @@ eb-roms.h: Config
>       mv -f $@.new $@
>  
>  $T:
> -     if ! wget -O _$T $(IPXE_TARBALL_URL); then \
> -             $(GIT) clone $(IPXE_GIT_URL) $D.git; \
> -             (cd $D.git && $(GIT) archive --format=tar --prefix=$D/ \
> -             $(IPXE_GIT_TAG) | gzip >../_$T); \
> -             rm -rf $D.git; \
> -     fi
> +     $(GIT) clone $(IPXE_GIT_URL) $D.git; \
> +     (cd $D.git && $(GIT) archive --format=tar --prefix=$D/ \
> +     $(IPXE_GIT_TREE) | gzip >../_$T); \
> +     rm -rf $D.git; \
>       mv _$T $T
>  
>  $D/src/arch/i386/Makefile: $T Config

Please retain the option to have a tarball, so one can easily point
this to some local file (and not require a functional network, nor
having to tolerate the slowness of the cloning process, nor having
to have git installed everywhere).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel