Re: [Xen-devel] [PATCH 1 of 2] Re-name xenstore key used to save VM generation ID buffer address

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2011-12-14 at 09:31 +0000, Paul Durrant wrote:
> # HG changeset patch
> # User Paul Durrant <paul.durrant@xxxxxxxxxx>
> # Date 1323854952 0
> # Node ID fded65be5d82461e87de54960db14ce8feb4625f
> # Parent  03138a08366b895d79e143119d4c9c72833cdbcd
> Re-name xenstore key used to save VM generation ID buffer address.
> 
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> 
> diff -r 03138a08366b -r fded65be5d82 tools/firmware/hvmloader/acpi/build.c
> --- a/tools/firmware/hvmloader/acpi/build.c   Fri Dec 09 16:19:36 2011 +0000
> +++ b/tools/firmware/hvmloader/acpi/build.c   Wed Dec 14 09:29:12 2011 +0000
> @@ -309,7 +309,7 @@ unsigned long new_vm_gid(void)
>      if ( snprintf(addr, sizeof(addr), "0x%lx", virt_to_phys(buf))
>           >= sizeof(addr) )
>          return 0;
> -    xenstore_write("data/generation-id", addr);
> +    xenstore_write("data/generation-id-address", addr);

data/ seems like an odd home for this, isn't that the area where guests
can expect to store their own bits and bobs, agent stuff etc?

Although this key is going to be guest writeable (so hvmloader can write
it) it really ought to be off somewhere out of the way. We select the
bios with /local/domain/<domid>/hvmloader/bios so perhaps something
under there or /local/domain/<domid>/platform?

(/me adds "do archaeology and document valid/best-practice xenstore
paths to TODO list)

Ian.

>  
>      gid = strtoll(xenstore_read("platform/generation-id", "0"), NULL, 0);
>      *(uint64_t *)buf = gid;
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel