Re: [Xen-devel] [PATCH 4 of 8] Tools: Add a sharing command to xl for information about shared pages

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2011-12-09 at 23:15 +0000, Andres Lagar-Cavilla wrote:
> docs/man/xl.pod.1         |  18 +++++++++
>  tools/libxl/xl.h          |   1 +
>  tools/libxl/xl_cmdimpl.c  |  85 
> +++++++++++++++++++++++++++++++++++++++++++++++
>  tools/libxl/xl_cmdtable.c |   6 +++
>  4 files changed, 110 insertions(+), 0 deletions(-)
> 
> 
> Signed-off-by: Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>
> Signed-off-by: Adin Scannell <adin@xxxxxxxxxxx>
> 
> diff -r e16f5d2643c9 -r a22140d92931 docs/man/xl.pod.1
> --- a/docs/man/xl.pod.1
> +++ b/docs/man/xl.pod.1
> @@ -280,6 +280,24 @@ B<Warning:> There is no good way to know
>  mem-set will make a domain unstable and cause it to crash.  Be very
>  careful when using this command on running domains.
>  
> +=item B<sharing> [I<-t> I<--totals>] [I<domain-id>]
[...]
>  =item B<migrate> [I<OPTIONS>] I<domain-id> I<host>

The commands are (supposed to be) alphabetical within each section.

[...]
> diff -r e16f5d2643c9 -r a22140d92931 tools/libxl/xl_cmdimpl.c
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -3755,6 +3755,91 @@ int main_info(int argc, char **argv)
[...]
> +int main_sharing(int argc, char **argv)
> +{
> +    int opt;
> +    int option_index = 0;
> +    static struct option long_options[] = {
> +        {"help", 0, 0, 'h'},
> +        {"totals", 0, 0, 't'},
> +        {0, 0, 0, 0}
> +    };
> +    int totals = 0;
> +
> +    libxl_dominfo info_buf;
> +    libxl_dominfo *info, *info_free=0;
> +    int nb_domain, rc;
> +
> +    while ((opt = getopt_long(argc, argv, "ht", long_options, 
> &option_index)) != -1) {

Please use def_getopt().

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel