Re: [Xen-devel] [PATCH 6/6] xen/xenbus-backend: Only register device if communication ring is local

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Sat, 2011-12-10 at 18:29 +0000, Bastian Blank wrote:
> +/* A flag to determine if xenstored is 'local' */
> +#ifdef CONFIG_XEN_BACKEND
> +static int xenstored_local;
> +#endif

I think this can be __initdata since all the users are __init.

> +#ifdef CONFIG_XEN_BACKEND
> +                     xenstored_local = 1;

I would push this down into xenstore_local_init() and only set it on
success.

>                       err = xenstored_local_init();

This is now only called if CONFIG_XEN_BACKEND. You should add a similar
#ifdef around the function definition.

Ian.

>                       if (err)
>                               goto out_error;
> +#else
> +                     BUG();
> +#endif
>               }
>               xen_store_interface = mfn_to_virt(xen_store_mfn);
>       }



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel