Re: [Xen-devel] [PATCH 06/15] libxl: permit declaration after statement

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 7 Dec 2011, Ian Campbell wrote:
> On Mon, 2011-12-05 at 18:10 +0000, Ian Jackson wrote:
> > GCC and C99 allow declarations to be mixed with code.  This is a good
> > idea because:
> > 
> >  * It allows variables to be more often initialised as they are
> >    declared, thus reducing the occurrence of uninitialised variable
> >    errors.
> > 
> >  * Certain alloca-like constructs (arrays allocated at runtime on the
> >    stack) can more often be written without a spurious { } block.
> >    Such blocks are confusing to read.
> > 
> >  * It makes it easier to write and use macros which declare and
> >    initialise formulaic variables and do other function setup code,
> >    because there is no need to worry that such macros might be
> >    incompatible with each other or have strict ordering constraints.
> > 
> > Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> I'm happy with this so far as it goes but I was wondering where the
> original -Wdeclaration-after-statement came from, do we actually mean
> "-std=c99" or something along those lines?
> 
> Anyway I'm still ok with saying:
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Of course I still think that it is the wrong decision, but unfortunately
it seems that I am outnumbered on this.

Policy changes like this one, do the need the majority or unanimity?
:-)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel