[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 13/15] libxl: make LIBXL_INIT_GC a statement, not an initialiser



Ian Campbell writes ("Re: [Xen-devel] [PATCH 13/15] libxl: make LIBXL_INIT_GC a 
statement, not an initialiser"):
> On Mon, 2011-12-05 at 18:10 +0000, Ian Jackson wrote:
> > In fact there is only one caller now, GC_INIT,
> 
> Maybe we should just fold LIBXL_INIT_GC into GC_INIT then?

No, because GC_INIT is a non-hygienic convenience macro.  Such things
should never be the only implementation of some important interface,
because then if for any reason the lack of hygiene is a problem for
you you are stuck.

LIBXL_INIT_GC is the underlying functionality which may need to be
used in those other, less usual cases, and therefore still needs to
exist as a separate interface.

Indeed in my asynchronous operations code (patch(es) still very much a
work in progress) I will need to call LIBXL_INIT_GC outside GC_INIT.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.