[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] Re: [PATCH 6 of 9] x86/mm: Rework stale p2m auditing



>>> On 02.12.11 at 11:33, Tim Deegan <tim@xxxxxxx> wrote:
> At 08:28 +0000 on 02 Dec (1322814505), Jan Beulich wrote:
>> It uncovered a problem
>> in 22356:cbb6b4b17024 (the code meanwhile moved elsewhere): In a
>> 32-bit build,
>> 
>>         if ( gfn == 0x55555555 || gfn == 0x5555555555555555 )
>> 
>> causes (at least with some compiler versions, didn't check tonight's
>> stage tester results yet) a compiler warning 
> 
> I don't think these debug values are serving any purpose.  How about we
> just get rid of them? 
> 
> x86/mm: remove 0x55 debug pattern from M2P table
> 
> It's not really any more useful than explicitly setting new M2P entries
> to the invalid value.

That's fine by me - I don't think I ever found a need to distinguish
never touched from invalidated entries.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.