[Xen-devel] [PATCH 1/2] libxl: open logs with O_APPEND

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Logfiles should always be opened for append.

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

diff -r a9c67c2daf4b tools/libxl/libxl_dm.c
--- a/tools/libxl/libxl_dm.c    Mon Nov 28 11:57:23 2011 +0000
+++ b/tools/libxl/libxl_dm.c    Mon Nov 28 12:25:52 2011 +0000
@@ -830,7 +830,7 @@ int libxl__create_device_model(libxl__gc
     libxl__xs_write(gc, XBT_NULL, libxl__sprintf(gc, "%s/disable_pf", path), 
"%d", !info->xen_platform_pci);
 
     libxl_create_logfile(ctx, libxl__sprintf(gc, "qemu-dm-%s", 
info->dom_name), &logfile);
-    logfile_w = open(logfile, O_WRONLY|O_CREAT, 0644);
+    logfile_w = open(logfile, O_WRONLY|O_CREAT|O_APPEND, 0644);
     free(logfile);
     null = open("/dev/null", O_RDONLY);
 
diff -r a9c67c2daf4b tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c  Mon Nov 28 11:57:23 2011 +0000
+++ b/tools/libxl/xl_cmdimpl.c  Mon Nov 28 12:25:52 2011 +0000
@@ -1597,7 +1597,8 @@ start:
             exit(-1);
         }
 
-        CHK_ERRNO(( logfile = open(fullname, O_WRONLY|O_CREAT, 0644) )<0);
+        CHK_ERRNO(( logfile = open(fullname, O_WRONLY|O_CREAT|O_APPEND,
+                                   0644) )<0);
         free(fullname);
         free(name);
 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel