Re: [Xen-devel] [PATCH] Fix save/restore for HVM domains with viridian=1

[Tim Deegan <tim@xxxxxxx>]

At 15:14 +0000 on 25 Nov (1322234058), Paul Durrant wrote:
> > > @@ -411,6 +417,8 @@ static int viridian_load_domain_ctxt(str
> > >      if ( hvm_load_entry(VIRIDIAN_DOMAIN, h, &ctxt) != 0 )
> > >          return -EINVAL;
> > >
> > > +    ASSERT(is_viridian_domain(d));
> > > +
> > 
> > I don't think it's appropriate to crash Xen if the save file is
> > bogus.
> > 
> 
> There's a similar ASSERT in the hypercall function anyway; would you rather I 
> turned that into a rate limited warning too?
> 

If you mean the one in viridian_hypercall(), no - if that function is
called for a non-viridian VM that's a bug in Xen so the ASSERT() is
correct.   

The viridian_load_*_ctxt() functions are called based on the HVM save
record the tools gave us, so we should at most return an error if they
lead us astray.  And I think it should be OK to load the HVM state and then
set the HVM params, so the current (lack of) response is correct. 

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel