[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] tools: misc: xen-tmem-list-parse: fix output ugliness



Dan Magenheimer writes ("Re: [Xen-devel] [PATCH] tools: misc: 
xen-tmem-list-pars> No, it doesn't.  I agree it *could* if parse_string is
> used/called differently.  The caller simply needs to
> ensure that the declared buffer is at least one larger
> than the data to be matched which is true for both
> callers.

Urgh.  So in the previous code the buffer was a byte too big ?

I think functions with prototypes like
     f(int len, char *buf)
should take buf[len], not buf[len+1].

> P.S. Please note that I am still not receiving email
> >from the xen-devel reflector (and am on vacation this
> week so probably won't be looking into it... my best
> guess is that the Oracle spam filter isn't happy with
> the new source of the xen-devel messages, as some
> other Oracle folk are having problems too).

Hrmm.  If this is still a problem when you get back please let me know.

ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.