RE: [Xen-devel] RE: [PATCH] Make lock profiling usable again

["Hao, Xudong" <xudong.hao@xxxxxxxxx>]

> -----Original Message-----
> From: Juergen Gross [mailto:juergen.gross@xxxxxxxxxxxxxx]
> Sent: Monday, November 07, 2011 1:52 PM
> To: Hao, Xudong
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] RE: [PATCH] Make lock profiling usable again
> 
> Xudong,
> 
> I found that bug after sending you the patch and included the correction
> already in the version sent to xen-devel.
> 

OK, thanks.

> 
> Juergen
> 
> On 11/05/2011 05:10 AM, Hao, Xudong wrote:
> > Initialize profile to NULL when lock profiling is not enabled.
> >
> > diff -r 068d3d55ce6e xen/include/xen/spinlock.h
> > --- a/xen/include/xen/spinlock.h        Tue Nov 01 19:03:38 2011 +0000
> > +++ b/xen/include/xen/spinlock.h        Sat Nov 05 11:57:38 2011 +0800
> > @@ -108,7 +108,7 @@ struct lock_profile_qhead { };
> >   struct lock_profile_qhead { };
> >
> >   #define SPIN_LOCK_UNLOCKED
> \
> > -    { _RAW_SPIN_LOCK_UNLOCKED, 0xfffu, 0, _LOCK_DEBUG, { } }
> > +    { _RAW_SPIN_LOCK_UNLOCKED, 0xfffu, 0, _LOCK_DEBUG, NULL }
> >   #define DEFINE_SPINLOCK(l) spinlock_t l = SPIN_LOCK_UNLOCKED
> >
> >   #define spin_lock_init_prof(s, l) spin_lock_init(&((s)->l))
> >
> >
> > Thanks,
> > -Xudong
> >
> >
> >> -----Original Message-----
> >> From: Juergen Gross [mailto:juergen.gross@xxxxxxxxxxxxxx]
> >> Sent: Friday, November 04, 2011 8:53 PM
> >> To: xen-devel@xxxxxxxxxxxxxxxxxxx
> >> Cc: Hao, Xudong
> >> Subject: [PATCH] Make lock profiling usable again
> >>
> >> Using lock profiling (option lock_profile in xen/Rules.mk) resulted in 
> >> build
> errors.
> >> Changes:
> >> - Include public/sysctl.h in spinlock.h when using lock profiling.
> >> - Allocate profile data in an own structure to avoid struct domain becoming
> >>    larger then one page
> >>
> >> Signed-off-by: juergen.gross@xxxxxxxxxxxxxx
> >>
> >>
> >> 2 files changed, 44 insertions(+), 24 deletions(-)
> >> xen/common/spinlock.c      |   34 +++++++++++++++++++++-------------
> >> xen/include/xen/spinlock.h |   34 +++++++++++++++++++++++-----------
> >>
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxxxxxxxx
> > http://lists.xensource.com/xen-devel
> >
> >
> 
> 
> --
> Juergen Gross                 Principal Developer Operating Systems
> PDG ES&S SWE OS6                       Telephone: +49 (0) 89 3222
> 2967
> Fujitsu Technology Solutions              e-mail:
> juergen.gross@xxxxxxxxxxxxxx
> Domagkstr. 28                           Internet: ts.fujitsu.com
> D-80807 Muenchen                 Company details:
> ts.fujitsu.com/imprint.html


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel