[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [PATCH RFC V2 3/5] kvm hypervisor : Add two hypercalls to support pv-ticketlock



On 10/24/2011 03:44 PM, Avi Kivity wrote:
On 10/23/2011 09:05 PM, Raghavendra K T wrote:
Add two hypercalls to KVM hypervisor to support pv-ticketlocks.
+
+end_wait:
+       finish_wait(&vcpu->wq,&wait);
+}

This hypercall can be replaced by a HLT instruction, no?

I'm pretty sure this misses a lot of stuff from kvm_vcpu_block().

Yes.. agree. HLT sounds better idea. 'll try this out.


+       if (vcpu) {
+               vcpu->kicked = 1;

Need to use smp memory barriers here.

Agree.


+               wake_up_interruptible(&vcpu->wq);
+       }
+}
+
  int kvm_emulate_hypercall(struct kvm_vcpu *vcpu)
  {
        unsigned long nr, a0, a1, a2, a3, ret;




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.