[Xen-devel] Re: [PATCH 1/5] xen-pcifront: Update warning comment to use 'e820_host' option.

[Joe Perches <joe@xxxxxxxxxxx>]

On Wed, 2011-08-24 at 18:31 -0400, Konrad Rzeszutek Wilk wrote:
> With Xen changeset 23428 "libxl: Add 'e820_host' option to config file"
> the E820 as seen from the host can now be passed into the guest.
> This means that a PV guest can now:
>  - Use the correct PCI I/O gap. Before these patches, Linux guest would
>    boot up and would tell:
>    [    0.000000] Allocating PCI resources starting at 40000000 (gap: 
> 40000000:c0000000)
>    while in actuality the PCI I/O gap should have been:
>    [    0.000000] Allocating PCI resources starting at b0000000 (gap: 
> b0000000:4c000000)
>  - The PV domain with PCI devices was limited to 3GB. It now can be booted
>    with 4GB, 8GB, or whatever number you want. The PCI devices will now _not_ 
> conflict
>    with System RAM. Meaning the drivers can load.
[]
> diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c
[]
> @@ -401,8 +401,8 @@ static int pcifront_claim_resource(struct pci_dev *dev, 
> void *data)
>                               pci_name(dev), i);
>                       if (pci_claim_resource(dev, i)) {
>                               dev_err(&pdev->xdev->dev, "Could not claim "
> -                                     "resource %s/%d! Device offline. Try "
> -                                     "giving less than 4GB to domain.\n",
> +                                     "resource %s/%d! Device offline. Try"
> +                                     "using e820_host=1 in the guest 
> config.\n",

Trivia: You lost the space after "Try".

It's generally better not to split format strings into
multiple pieces.

Perhaps:
                                dev_err(&pdev->xdev->dev, "Could not claim 
resource %s/%d! Device offline. Try using e820_host=1 in the guest config.\n",

or
                                dev_err(&pdev->xdev->dev, "Could not claim 
resource %s/%d! "
                                        "Device offline. Try using e820_host=1 
in the guest config.\n",



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel