[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Re: [PATCH] libxl: clean up trailing whitespaces in code. [and 1 more messages]

On Mon, 2011-07-18 at 14:56 +0100, Ian Jackson wrote:
> Wei Liu writes ("[Xen-devel] [PATCH] libxl: clean up trailing whitespaces in 
> code."):
> > commit 46926d5d610d8f6cf60ede47ce0c40a63a2c9e43
> > Author: Wei Liu <liuw@xxxxxxxxx>
> > Date:   Sat Jul 16 16:01:57 2011 +0800
> > 
> >     libxl: clean up trailing whitespaces in code.
> >     
> >     find -not -iname '*.txt' -type f -print0 | xargs -0 sed -i.bak -E 
> > 's/[[:space:]]*$//'
> Thanks.  I'm inclined to take this patch, but I'd like to coordinate
> with other people who might have outstanding patch queues for libxl.
> So: if anyone has outstanding libxl patches other than Ian Campbell's
> IDL enum series, please let me know whether I should wait, or whether
> you're happy dealing with rebasing your patches across the whitespace
> change.
> Wei Liu: can you confirm that the patch you attached was /exactly/ the
> output of that rune ?  If so I can just rerun it.  If not then what
> are the things you had to fix up ?

I just run the command in libxl directory and commit all changes. Then I
generate the patch with

  $ git show HEAD > ~/libxl-whitespace-cleanup.patch

The attached patch should be correct. No fixup is required.

I also re-compile libxl, all goes well.


> Thanks,
> Ian.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.