Re: [Xen-devel] [PATCH] libxc: set CPUID topology leaf as unsupported for PV guests

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> On 14.07.11 at 16:25, David Vrabel <david.vrabel@xxxxxxxxxx> wrote:
> On 14/07/11 14:30, Keir Fraser wrote:
>> On 14/07/2011 12:50, "David Vrabel" <david.vrabel@xxxxxxxxxx> wrote:
>> 
>>> libxc: set CPUID topology leaf as unsupported for PV guests
>>>
>>> The result of a CPUID Extended Topology Enumeration leaf for PV guests
>>> is invalid as the level in ECX is ignored.  This can cause some guests
>>> to loop endlessly when trying to enumerate the topology.
>>>
>>> Since the physical topology isn't useful to PV guests set the topology
>>> leaf as unsupported.
>> 
>> For future reference, you also need to modify
>> xen/arch/x86/traps.c:pv_cpuid(), for dom0.
> 
> Looking at the code it looks like dom0 would at least see valid data for
> the the topology leaf.  But I guess the info makes no sense to dom0 as
> well as domU guests.  Patch sent if you've not already fixed it up.

It may make limited sense to Dom0 if "dom0_vcpus_pin" is in effect.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel