[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/2] Xen: enabling emulated MSI injection


  • To: Tim Deegan <Tim.Deegan@xxxxxxxxxx>, Wei Liu <liuw@xxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxx>
  • Date: Thu, 26 May 2011 10:10:51 +0100
  • Cc: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
  • Delivery-date: Thu, 26 May 2011 02:12:04 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=A1mLjXTeqS5DqFuW7qrIcTqRQvoahXBRN51DVeSUdnFATQBnDhQdtg1cH2gM3S1eOv Tgz9fvpOf2H9g5CvuU2hV9NKORkRgH1RTWug7VMv6lurYJ1biVBn0ip8Xx/96eH2EL4u a2DkFDfid653YPmRkdd2jMx2IsCZ/VzqsLIrk=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcwbhM8IkiXR7a0kS06ryku0hiC+QA==
  • Thread-topic: [Xen-devel] [PATCH 1/2] Xen: enabling emulated MSI injection

On 26/05/2011 09:43, "Tim Deegan" <Tim.Deegan@xxxxxxxxxx> wrote:

>> +/* MSI injection for emulated devices */
>> +#define HVMOP_inj_msi         16
>> +struct xen_hvm_inj_msi {
>> +    /* Domain to be injected */
>> +    domid_t   domid;
>> +    /* Address (0xfeeXXXXX) */
>> +    uint64_t  addr;
>> +    /* Data -- lower 32 bits */
>> +    uint32_t  data;
>> +};
> 
> Please rearrange this so that it has the same size and layout on 32-bit
> and 64-bit builds.

You can do this most easily be simply swapping the second and third fields.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.