Re: [Xen-devel] Re: [PATCH 0 of 8] Remove static variables from xc_domain_{save, restore}.c

[Shriram Rajagopalan <rshriram@xxxxxxxxx>]

On Tue, May 24, 2011 at 1:52 PM, Ian Campbell
<Ian.Campbell@xxxxxxxxxxxxx> wrote:
>
> On Tue, 2011-05-24 at 18:02 +0100, Ian Jackson wrote:
> > Shriram Rajagopalan writes ("[Xen-devel] Re: [PATCH 0 of 8] Remove static 
> > variables from xc_domain_{save, restore}.c"):
> > > I ll do it!!.. I have been waiting for this. Thanks a lot for
> > > cleaning up this chaff!  I was under the impression that this was
> > > some arcane legacy code that shouldnt be touched.
> >
> > No, it's arcane legacy code that we have been gradually cleaning up
> > :-).
> >
> > > One particular
> > > thing that I would like to do is to factor out the write functions
> > > (outbuf_*, noncached_write, ratewrite*, etc) into a separate file
> > > and make it sort of pluggable.
> >
> > Do you have a particular use case fot that ?  Without a different set
> > of implementations I'm not sure that we need it to be pluggable.
> >
> > > (selfish :P) I wanted to introduce a patch that would overlap outbuf
> > > flush operation and guest memory copy operation instead of the
> > > current model <flush,copy,flush,copy..>.  This might be helpful for
> > > both Remus and live migration of large domains.
> >
> > But yes, if that produces a speedup, certainly.
> >
> > >  Shriram, does this have any impact on Remus?
> >
> > I think it should be OK but we should hear what Shriram has to say
> > (CC'd).
>
> You were replying to Shriram ;-)
>
> Ian.
>
>
>
Ok. I ve tested it with remus. works properly :).

Acked-by: Shriram Rajagopalan <rshriram@xxxxxxxxx>

thanks
shriram

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel