[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: Fwd:[PATCH-may be a bug ignored] tools/libxl/libxl__build_device_model_args_new/old: The condition is so rigorous that user has no chance to disable the vnc


  • To: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
  • From: ZhouPeng <zpengxen@xxxxxxxxx>
  • Date: Thu, 21 Apr 2011 09:02:16 +0800
  • Cc: "Xen-Devel \(E-mail\)" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
  • Delivery-date: Wed, 20 Apr 2011 18:03:24 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=i/GYV8Yra4jNVPYppwS0FKNGAWouE1pn1ixfpBmthBrfZn3CWtSn6/mPagH9lXYoBS Xdjc3EGKXQ0wP6YqgGQHI6MV07ci9OSvhvZTWVRZUBXtAOicsgTTEFeGJCzm5mIZVbVD 2e2qwasm4vnWqj+gmTyB9xq3eoHgkPz8pEKGw=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

Thanks.

2011/4/20 Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>:
> On Wed, 20 Apr 2011, ZhouPeng wrote:
>> In my spice testing,
>> I find user have no way to disable vnc in qemu-old and new using xl,
>> no matter how to set
>> "vnc vncunused vncpasswd vncdisplay vnclisten" in vm cfg file.
>>
>> I think this may be a bug ignored.
>>
>> Signed-off-by: Zhou Peng <zhoupeng@xxxxxxxxxxxxxxx>
>>
>> tools/libxl/libxl__build_device_model_args_new/old: The condition is
>> so rigorous that user has no chance to disable the vnc,
>> considering what has been done in parse_config_data() by default,
>> which is not resonable with vnc option in vm-cfg file.
>>
>> I think, If user explicitly set "vnc=0", vnc should be disabled.
>> User should have the chance to only use sdl, other remote
>> display(spice) and even nothing.
>>
>
>
> Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
>
>



-- 
Zhou Peng
Operating System Technology Group
Institute of Software, the Chinese Academy of Sciences (ISCAS)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.