[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH] x86: don't write_tsc() non-zero values on CPUs updating only the lower 32 bits



> -----Original Message-----
> From: Keir Fraser [mailto:keir.xen@xxxxxxxxx]
> Sent: Thursday, April 14, 2011 2:06 PM
> On 14/04/2011 19:33, "Wang, Winston L" <winston.l.wang@xxxxxxxxx> wrote:
> 
> > Jan and Keir,
> >
> > Great efforts for turning the test code re-validate the processor
> with
> > (X86_FEATURE_TSC_RELIABLE) set. We know for sure that the broken old
> > processors any write TSC will Zero the upper 32 bit. So can we move
> this test
> > code as early as possible, say immediately after the early Processor
> init code
> > where checking CPU id and set X86_FEATURE_TSC_RELIABLE?
> 
> For our meaning of TSC_RELIABLE, there's no need for its setting to
> rely on
> TSC 64-bit writability. I think leaving it where it is in
> init_xen_time() is probably fine.

It's fine with me.

Winston,


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.