Re: [Xen-devel] [PATCH 17 of 19] tools: libxl: hide selection of device-model, hvmloader and BIOS by default

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[Xen-devel] [PATCH 17 of 19] tools: libxl: hide selection 
of device-model, hvmloader and BIOS by default"):
> At the libxl API level:
...
>       * Add libxl_device_model_info.device_model_version allowing the
>         user to say which qemu version (e.g. old qemu-xen or qemu
>         upstream) they want for a domain.

Perhaps this ought to be a series of #defines, rather than an
integer ?  Integers have the virtue of sortability but it's not clear
that that's important; a series of #defines and corresponding strings
would be easier in the config file I think.

> -        if (strstr(dm_info->device_model, "stubdom-dm"))
> +        if (strstr(libxl__domain_device_model(&gc, dm_info), "stubdom-dm"))
>              *need_memkb += 32 * 1024;

Surely this strstr(,"stubdom-dm",) can be got rid of too, in favour of
"stubdom=1" or something ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel