[Xen-devel] RE: [PATCH][VTD] check BIOS settings before enabling interrupt remapping or x2apic

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> On 05.04.11 at 20:10, "Kay, Allen M" <allen.m.kay@xxxxxxxxx> wrote:
> Removed __init modifier for platform_supports_intremap() and 
> platform_supports_x2apic().

Sorry, but removing the __init from just the definitions isn't sufficient
(normally the declarations shouldn't have these added, but as you
did they'll need to be removed there too).

Jan

> Signed-off-by: Allen Kay <allen.m.kay@xxxxxxxxx>
> 
> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxxxx] 
> Sent: Tuesday, April 05, 2011 3:53 AM
> To: Kay, Allen M
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx; Keir Fraser
> Subject: Re: [PATCH][VTD] check BIOS settings before enabling interrupt 
> remapping or x2apic
> 
>>>> On 29.03.11 at 19:58, "Kay, Allen M" <allen.m.kay@xxxxxxxxx> wrote:
>> Check flags field in ACPI DMAR structure before enabling interrupt remapping 
> 
>> or x2apic.  This allows platform vendors to disable interrupt remapping or 
>> x2apic features if on board BIOS does not support them.
>> 
>> Signed-off-by: Allen Kay <allen.m.kay@xxxxxxxxx>
> 
> Marking platform_supports_intremap() and platform_supports_x2apic()
> __init isn't correct - both get called from the resume path.
> 
> Jan




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel