Re: [Xen-devel] [PATCH] xenstore-stat

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

(I saw the second posting but the same issues are present there so I
reply here to keep the conversational context)

On Wed, 2011-03-30 at 13:03 +0100, Frank Pan wrote:

> >> +    case MODE_stat:
> >> +        mstr = incl_mode ? "stat " : "";
> >> +        errx(1, "Usage: %s %s[-h] [-s] key [...]", progname, mstr);
> >
> > Does it deal with multiple key names as a paramter? If not then I guess
> > the [...] can be dropped, or else the necessary support added.
> 
> Sure, xenstore-stat can accept multiple keys.

But it doesn't have a loop over optind or anything. It looks to me like
it will just print the info for the first key.

> >> +static const char *
> >> +perm_type_str(int perm_type)
> >> +{
> >
> > Can you use xs_perm_to_string here instead?
> 
> I'd like to make it more similar to unix permissions. ("-rwx")
> I think it's more straightforward than "w/r/b/n".
> Is this a good idea?

I'm not sure. The current xs way of doing things is odd compared with
unix permissions but it's what people are used to and what they need to
type as n argument to xenstore-chmod. The last point is particularly
compelling IMHO.

> 
> > Unused parameter?
> 
> Yes. My compiler did not complain, weird.
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel