Re: [Xen-devel] Re: [Qemu-devel] [PATCH V11 00/15] Xen device model support

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Tue, Mar 22, 2011 at 14:23, Alexander Graf <agraf@xxxxxxx> wrote:
> On 03/01/2011 07:35 PM, anthony.perard@xxxxxxxxxx wrote:
>>
>> From: Anthony PERARD<anthony.perard@xxxxxxxxxx>
>>
>> Hi all,
>>
>> Here is the few change since the V10:
>>
>> Â - Add braces for blocks with single statement in the clean-up patch;
>> Â - the patch that builds Xen only for x86 have been removed, instead,
>> Â Â xen_domainbuild is built with libhw and other Xen files are built for
>> i386
>> Â Â target only;
>> Â - the redirection structure with function pointer have been removed,
>> instead,
>> Â Â there are few #define or static inline function use for the
>> compatibility;
>
> ARGH!
>
> The point of the redirection structure was so I can plug in with xenner and
> replace all the xen calls with in-qemu versions. If you remove it, I'll have
> to put it back in in the xenner patch set :(.
>
> We need some sort of abstraction between calling xs_ functions and actually
> calling them. Wrapping all xs_ calls in static inlines would be fine for
> that, as would the indirect calling table.

As my series doesn't change a lot of things in the xen code, I think
it is better than you put it back in your patch set.

Regards,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel