[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [Patch] remove unneeded test for cpu in cpupool


  • To: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Przywara, Andre" <Andre.Przywara@xxxxxxx>
  • From: Keir Fraser <keir.xen@xxxxxxxxx>
  • Date: Wed, 16 Mar 2011 10:13:42 +0000
  • Cc:
  • Delivery-date: Wed, 16 Mar 2011 03:15:28 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=u/GC0cV9PQaYWD+eFrUoBG7Tsw6ka9yPfMZ2PE7KIePJyV/+OOwjpyQD4b9bot0qZR J+P4P8BTo/k0d0LHhK0//DDnlwtedZpWrrzYc6v/jjlz1QE4HTJj+vfT4RfMZlMp/vyM FFcDy/Xc1Z9iy3chiX3KtuDxgQmePy46/EWtQ=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcvjwtNlH0yWhetBG06wqhuYON9uQg==
  • Thread-topic: [Xen-devel] [Patch] remove unneeded test for cpu in cpupool

On 16/03/2011 06:34, "Juergen Gross" <juergen.gross@xxxxxxxxxxxxxx> wrote:

> Hi,
> 
> attached patch removes an unneeded check in vcpu_migrate().
> 
> Andre, could you please give it a try on your 48 core machine with
> 
> xl cpupool-numa-split
> 
> I'd like to make sure the check is really not needed. On my machines it worked
> okay, but your machine seems to trigger races more easily.

Could you BUG_ON failing this test when we exit the retry loop? It seems a
suitable loop post-condition.

 -- Keir

> 
> Juergen



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.